Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize tests to allow us to reenable testing in pkg/... #63

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

klueska
Copy link
Contributor

@klueska klueska commented Apr 23, 2024

No description provided.

@klueska klueska force-pushed the reenable-tests branch 2 times, most recently from 1892063 to 320faaf Compare April 23, 2024 16:36
@klueska
Copy link
Contributor Author

klueska commented Apr 23, 2024

All of the unit tests are passing locally, but one is failing on github. Investigating ...

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a matter of interest, are there particular tests that take a long time, or why is the parallelisation requried?

@klueska
Copy link
Contributor Author

klueska commented Apr 23, 2024

Yes, the tests were (locally) taking over 20 minutes to complete and now they finish in under 1

@ArangoGutierrez ArangoGutierrez added the testing issue/PR to fix/edit/create/enhance a project unit/e2e test label Apr 23, 2024
@klueska
Copy link
Contributor Author

klueska commented Apr 23, 2024

OK, tests are passing now

@klueska klueska force-pushed the reenable-tests branch 2 times, most recently from 47da1d3 to ca399c4 Compare April 23, 2024 21:12
@klueska klueska merged commit 95b6677 into NVIDIA:main Apr 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing issue/PR to fix/edit/create/enhance a project unit/e2e test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants